bpo-36668: FIX reuse semaphore tracker for child processes#5172
Merged
pitrou merged 12 commits intopython:masterfrom Apr 24, 2019
Merged
bpo-36668: FIX reuse semaphore tracker for child processes#5172pitrou merged 12 commits intopython:masterfrom
pitrou merged 12 commits intopython:masterfrom
Conversation
pppery
reviewed
Feb 23, 2018
20a6b06 to
0a576a3
Compare
0a576a3 to
d9b23e1
Compare
pierreglaser
added a commit
to pierreglaser/loky
that referenced
this pull request
Mar 20, 2019
pierreglaser
added a commit
to pierreglaser/loky
that referenced
this pull request
Mar 20, 2019
ZackerySpytz
reviewed
Apr 7, 2019
Co-Authored-By: tomMoral <thomas.moreau.2010@gmail.com>
Contributor
Author
|
@pitrou This PR avoid spawning |
Contributor
Author
|
@pitrou I think this PR is ready |
pitrou
reviewed
Apr 24, 2019
Member
pitrou
left a comment
There was a problem hiding this comment.
Looks mostly good to me. Just a single comment.
Member
|
@tomMoral Can you force-push to trigger an AppVeyor build? |
Contributor
Author
|
Done |
|
@pitrou: Please replace |
Member
|
Thanks @tomMoral . I don't think this needs to be backported to 3.7, do you concur? |
Contributor
Author
|
@pitrou yes I agree this is not critical so it is not necessary to backport to 3.7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the
semaphore_trackercreates a new process for each children.This PR intends to fix this behavior.
The easy fix would be to pass the
_pidto the children but the current mechanism to check if thesemaphore_trackeris alive relies onwaitpidwhich cannot be used in child processes (thesemaphore_trackeris only a sibling of these processes). The main issue is to have a reliable check that either:waitpid, I don't see an efficient mechanism.I took the approach of adding a
PROBEcommand in the semaphore tracker. When the pipe is closed, the send command fails and this means the semaphore tracker is down.https://bugs.python.org/issue36668