Handle blank PO-Revision-Date and POT-Creation-Date headers#1258
Open
bysiber wants to merge 1 commit intopython-babel:masterfrom
Open
Handle blank PO-Revision-Date and POT-Creation-Date headers#1258bysiber wants to merge 1 commit intopython-babel:masterfrom
bysiber wants to merge 1 commit intopython-babel:masterfrom
Conversation
When a PO file has a blank PO-Revision-Date or POT-Creation-Date header (e.g. generated by Poedit), _parse_datetime_header raises a ValueError because it cannot parse an empty string. Skip parsing when the header value is blank, preserving the catalog's existing default values instead of crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a PO file has a blank
PO-Revision-Dateheader (e.g. generated by Poedit),_parse_datetime_headercrashes with aValueErrorbecause it tries to parse an empty string withstrptime.This adds a
value.strip()check before calling_parse_datetime_headerfor bothPO-Revision-DateandPOT-Creation-Dateheaders. When the value is blank, the catalog keeps its existing defaults instead of crashing.Fixes #1219