Fix SAML ticket verification failing when response is not namespaced #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 66.97% 66.97%
=======================================
Files 1 1
Lines 215 215
=======================================
Hits 144 144
Misses 71 71
Continue to review full report at Codecov.
|
Namespacing of the soap response is not necessary. If the response is not namespaced, the status code would be eg. `"Success"` instead of `"ns2:Success"` and cause the client to fail authentication when it had succeeded. We can remove the `:` in the expected status code end substring to support non namespaced responses.
db8275c to
9e8576d
Compare
Contributor
|
Thanks for your contribution! |
Contributor
Author
|
Hey @mingchen! I hope you are alright. Could we possibly merge this? I'm not in a hurry as I made a fork of |
Contributor
|
Merged. Thanks @mbenadda. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've encountered a problem where responses would be treated as though login had failed when they contained a
Successstatus code.I was able to track it down to ticket verification picking up status codes ending with
':Success'. This works fine when the response is namespaced (eg the code isns2:Success) but not otherwise (the code isSuccess).As far as I know, namespacing of the soap response is not necessary. If the response is not namespaced, the
":"in the string matcher will cause the client to fail authentication whenit had succeeded.
I think we can safely remove the
:in the expected status code end substring to support non namespaced responses.