Skip to content

fix(extension_sqlite3): Link required Rpcrt4 on Windows when UUID enabled #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jcfr merged 1 commit into from
Jan 15, 2026
Merged

fix(extension_sqlite3): Link required Rpcrt4 on Windows when UUID enabled #439

jcfr merged 1 commit into from
Jan 15, 2026
+1 −0

Conversation

@jamesobutler
Copy link
Contributor

@jamesobutler jamesobutler commented Jan 15, 2026

This resolves build issues on the Windows platform as seen below when the passed in sqlite3 was built with SQLITE_WIN32_USE_UUID enabled.

26>sqlite3_s.lib(sqlite3.obj) : error LNK2001: unresolved external symbol UuidCreate [C:\S5R4\python-build\CMakeBuild\extensions\extension_sqlite3.vcxproj]
26>sqlite3_s.lib(sqlite3.obj) : error LNK2001: unresolved external symbol UuidCreateSequential [C:\S5R4\python-build\CMakeBuild\extensions\extension_sqlite3.vcxproj]

@jamesobutler jamesobutler mentioned this pull request Jan 15, 2026
Merged
2 tasks
@jamesobutler jamesobutler requested a review from jcfr January 15, 2026 15:25
@jcfr
Copy link
Contributor

jcfr commented Jan 15, 2026

Thanks for the patch 🙏 Could you check how upstream cpython address this ? Is the library unconditionally specified ?

@jamesobutler
Copy link
Contributor Author

jamesobutler commented Jan 15, 2026

@jcfr Reviewing how cpython builds sqlite for itself (Python 3.12 version specifically), it appears that the preprocessor SQLITE_WIN32_USE_UUID isn't defined so sqlite isn't built with that UUID support that needs rpcrt4 on Windows.
https://github.com/python/cpython/blob/4a5632fbf9bf59477c540e3f53fa7cdbeea3e3f5/PCbuild/sqlite3.vcxproj#L101

@jcfr jcfr merged commit 5d89596 into python-cmake-buildsystem:master Jan 15, 2026
28 checks passed
@jamesobutler jamesobutler deleted the sqlite3-uuid-enabled branch January 15, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcfr jcfr jcfr approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamesobutler @jcfr