Closed
Conversation
Contributor
|
This is nice. I think the name and description is a bit confusing and not very precise: there are lots of performers that return effects. e.g. otter's perform_retry and concretize_service_request and these wouldn't benefit from this wrapper. This decorator is specifically useful for wrapper effects that want to change the way nested effects are performed by extending or otherwise changing the dispatcher. I won't suggest any better names/descriptions yet. we can think on it :) |
Contributor
|
I'm closing this because it's been sitting here for over four years, and I don't think I'm going to do anything with it any time soon (´。_。`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A performer for intents that return effect. This is idea I had. Will add tests after initial review. For example, tenant scope performer can be written as: