Skip to content

fix is_online() #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
patkan merged 4 commits into from
May 2, 2018
Merged

fix is_online() #282

patkan merged 4 commits into from
May 2, 2018

Conversation

@thijstriemstra
Copy link
Contributor

@thijstriemstra thijstriemstra commented Feb 12, 2018

fixes #275

  • [x ] I have tested this on an Epson TM-T88IV.

@thijstriemstra thijstriemstra mentioned this pull request Feb 12, 2018
Closed
@thijstriemstra
Copy link
Contributor Author

thijstriemstra commented Apr 30, 2018

ping @patkan, is this PR ok, any feedback?

@patkan
Copy link
Member

patkan commented May 2, 2018

Hi @thijstriemstra,
sorry for the delay. I don't get around to doing much at the moment and therefore still haven't fixed the Travis-builds. But your PR looks good to me and I will merge it now. As always, thank you very much for your contributon! 👍

@patkan patkan merged commit 4390dc4 into python-escpos:development May 2, 2018
@thijstriemstra thijstriemstra deleted the patch-3 branch May 2, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

is_online() is broken

2 participants

@thijstriemstra @patkan