chore: remove unused ALLOWED_KEYSET_ENDPOINTS variable#1300
Merged
nejch merged 1 commit intopython-gitlab:masterfrom Feb 16, 2021
JohnVillalovos:remove_cruft
Merged
chore: remove unused ALLOWED_KEYSET_ENDPOINTS variable#1300nejch merged 1 commit intopython-gitlab:masterfrom JohnVillalovos:remove_cruft
nejch merged 1 commit intopython-gitlab:masterfrom
JohnVillalovos:remove_cruft
Conversation
Member
|
I think this can go for now but for context, it was meant to follow endpoints where GitLab supports keyset pagination but it seems they're so far still stuck with only /projects (https://docs.gitlab.com/ee/api/README.html#keyset-based-pagination) and it broke some people's workflows initially due to missing headers. @max-wittig maybe we can re-add this e.g.to |
Member
|
They clearly stated that their not gonna re-add X-Total-Items. Maybe we just have to document this, when you switch the default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable ALLOWED_KEYSET_ENDPOINTS was added in commit
f86ef3b.
Then most of that commit was removed in commit
e71fe16, but ALLOWED_KEYSET_ENDPOINTS
was missed.