test: attempt to make functional test startup more reliable#2188
Merged
Conversation
0a2f2a7 to
564ab74
Compare
564ab74 to
c829b26
Compare
nejch
reviewed
Jul 26, 2022
c829b26 to
d349e06
Compare
Codecov Report
@@ Coverage Diff @@
## main #2188 +/- ##
==========================================
+ Coverage 91.56% 95.56% +4.00%
==========================================
Files 81 81
Lines 5344 5344
==========================================
+ Hits 4893 5107 +214
+ Misses 451 237 -214
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d349e06 to
08f4313
Compare
nejch
reviewed
Jul 29, 2022
The functional tests have been erratic. Current theory is that we are starting the tests before the GitLab container is fully up and running. * Add checking of the Health Check[1] endpoints. * Add a 20 second delay after we believe it is up and running. * Increase timeout from 300 to 400 seconds [1] https://docs.gitlab.com/ee/user/admin_area/monitoring/health_check.html
08f4313 to
67508e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functional tests have been erratic. Current theory is that we are
starting the tests before the GitLab container is fully up and
running.
[1] https://docs.gitlab.com/ee/user/admin_area/monitoring/health_check.html