fix(cli): add ability to escape at-prefixed parameter#2513
Merged
nejch merged 2 commits intopython-gitlab:mainfrom Mar 11, 2023
Merged
fix(cli): add ability to escape at-prefixed parameter#2513nejch merged 2 commits intopython-gitlab:mainfrom
nejch merged 2 commits intopython-gitlab:mainfrom
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2513 +/- ##
==========================================
- Coverage 96.15% 96.13% -0.02%
==========================================
Files 87 87
Lines 5663 5665 +2
==========================================
+ Hits 5445 5446 +1
- Misses 218 219 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
reviewed
Mar 10, 2023
Member
nejch
left a comment
There was a problem hiding this comment.
Thanks a lot @pyhedgehog for this and for adding the tests. LGTM just a small suggestion for the docs.
Member
|
LGTM. @nejch I'll let you decide when to merge. |
JohnVillalovos
approved these changes
Mar 10, 2023
nejch
approved these changes
Mar 11, 2023
Member
nejch
left a comment
There was a problem hiding this comment.
Thanks @pyhedgehog and @JohnVillalovos!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2511