feat(projects): add optional parameter to set approval rule on all pr…#3374
Open
shehzadqureshi wants to merge 1 commit intopython-gitlab:mainfrom
Open
feat(projects): add optional parameter to set approval rule on all pr…#3374shehzadqureshi wants to merge 1 commit intopython-gitlab:mainfrom
shehzadqureshi wants to merge 1 commit intopython-gitlab:mainfrom
Conversation
…otected branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds a parameter
applies_to_all_protected_branchesto project approval rule, that allows us to apply approval rules to all protected branches rather than enumerating the branches.This is a documented feature in the API: https://docs.gitlab.com/api/merge_request_approvals/#create-an-approval-rule-for-a-project
Documentation and testing
I tested this by building a local docker container and executing it against my Gitlab Premium/Ultimate self-hosted service.
toxtests also pass locally.Fixes #3372