Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request reorganizes and clarifies the GitHub Actions workflows for testing, specifically separating out "contrib" tests from other Python tests and improving how test paths are handled for various frameworks. The changes rename workflow files, update job and matrix naming conventions, and enhance test execution logic to include both integration and unit tests where applicable.
Workflow renaming and restructuring:
.github/workflows/integration-tests.ymlto.github/workflows/contrib-tests.ymland updated naming conventions throughout the workflow to use "contrib" instead of "integration".contrib_matrixjob to usecontribas the key, and added explicit paths for integration and unit tests for each framework.Test execution improvements:
contrib-tests.ymlto dynamically include both integration and unit test paths if they exist, allowing for more comprehensive testing per framework.Coverage reporting updates:
Python tests workflow update:
tests/integration/contribandtests/unit/contribdirectories during standard test runs, ensuring separation from contrib-specific tests.