refactor(parsers)!: remove default_bump_level from commit parsers#1374
Draft
refactor(parsers)!: remove default_bump_level from commit parsers#1374
default_bump_level from commit parsers#1374Conversation
Remove the default_bump_level setting from conventional-commit, scipy, and emoji parsers. - Removed default_bump_level field from ConventionalCommitParserOptions - Removed default_level_bump and default_bump_level from ScipyParserOptions - Removed default_bump_level field from EmojiParserOptions - Updated code to use LevelBump.NO_RELEASE directly instead of self.options.default_bump_level - Updated tag_to_level dict construction to use LevelBump.NO_RELEASE instead of default_bump_level - Updated tests to remove references to default_bump_level - Added new tests to verify parsers work correctly with other_allowed_tags BREAKING CHANGE: The `default_bump_level` configuration option has been removed from the conventional-commit, scipy, and emoji commit parsers. This option was redundant as the parser already maps commit types to bump levels. If you were using this option in your configuration, you can remove it. The parsers will now use LevelBump.NO_RELEASE for commit types not explicitly mapped to a bump level, which is the same behavior as the previous default. Co-authored-by: codejedi365 <17354856+codejedi365@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove default_bump_level setting from commit parsers
refactor(parsers)!: remove Nov 12, 2025
default_bump_level from commit parsers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove the redundant
default_bump_levelconfiguration option from conventional-commit, scipy, and emoji parsers. The option duplicates functionality already provided by explicit commit type to bump level mappings.Rationale
Each parser's
tag_to_levelmapping already defines bump levels for all recognized commit types. Thedefault_bump_levelwas only used as a fallback inzip_longestoperations during map construction—a confusing indirection that obscured actual behavior. Removing it eliminates configuration complexity without changing semantics: unrecognized commit types now explicitly receiveLevelBump.NO_RELEASEinstead of a configurable default.Before:
After:
How did you test?
default_bump_levelto verifyNO_RELEASEbehaviorother_allowed_tagscorrectlyHow to Verify
Run the test suite:
Check that parsers correctly assign
NO_RELEASEto unmatched commit types without configuration errors.PR Completion Checklist
Reviewed & followed the Contributor Guidelines
Changes Implemented & Validation pipeline succeeds
Commits follow the Conventional Commits standard
and are separated into the proper commit type and scope (recommended order: test, build, feat/fix, docs)
Appropriate Unit tests added/updated
Appropriate End-to-End tests added/updated
Appropriate Documentation added/updated and syntax validated for sphinx build (see Contributor Guidelines)
BREAKING CHANGE: The
default_bump_leveloption has been removed from conventional-commit, scipy, and emoji parser configurations. Remove this option from yourpyproject.tomlif present. Behavior unchanged: unrecognized commit types receiveNO_RELEASE.Closes #1293, #700
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.