chore: upgrade click to ~8.3.0#1411
Open
svmhdvn wants to merge 1 commit intopython-semantic-release:masterfrom
Open
chore: upgrade click to ~8.3.0#1411svmhdvn wants to merge 1 commit intopython-semantic-release:masterfrom
svmhdvn wants to merge 1 commit intopython-semantic-release:masterfrom
Conversation
Contributor
Author
|
Yes, I can help figure out how to fix the tests. Other than |
b0dd183 to
b7ad1fb
Compare
Author
|
My latest changes should pass all tests as reflected by https://github.com/svmhdvn/python-semantic-release/actions/runs/20724583139. |
Necessary changes due to this upgrade: * Minimum python version has been bumped to oldest currently supported version 3.10. Versions 3.8 and 3.9 are officially EOL. * `test_main_no_args_passes_w_help_text` testcase fixed to reflect exit code of 2 as mentioned in https://github.com/pallets/click/releases/tag/8.2.0 release notes * `tests/e2e/cmd_config/test_generate_config.py` testcases fixed to use `stdout` for LHS vs RHS diffing * `CliRunner` construction fixed to reflect `mix_stderr` being removed in click 8.2.0 as mentioned in https://github.com/pallets/click/releases/tag/8.2.0 release notes
Author
|
Anything further to do in this review? This should be good to go. |
Contributor
|
No, the changes make sense. Is there anyway to maintain support for 3.9? |
Author
|
No, because it seems that even click 8.2.0 doesn't support python 3.9: https://github.com/pallets/click/releases/tag/8.2.0 Since python 3.9 is already EOL, I think there's no harm in moving to python 3.10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This patch upgrades click to latest upstream master ~8.3.0.
Necessary changes due to this upgrade:
test_main_no_args_passes_w_help_texttestcase fixed to reflect exit code of 2 as mentioned in https://github.com/pallets/click/releases/tag/8.2.0 release notestests/e2e/cmd_config/test_generate_config.pytestcases fixed to usestdoutfor LHS vs RHS diffingCliRunnerconstruction fixed to reflectmix_stderrbeing removed in click 8.2.0 as mentioned in https://github.com/pallets/click/releases/tag/8.2.0 release notesRationale
Distributions with static package versions need to upgrade
clickto latest upstream version, but cannot do so without bringing this port's dependency onclickto the latest upstream version.How did you test?
tox -rpytest -vv --comprehensiveHow to Verify
N/A
PR Completion Checklist
and are separated into the proper commit type and scope (recommended order: test, build, feat/fix, docs)