Skip to content

Conversation

@Bibo-Joshi
Copy link
Member

Check-list for PRs

  • Added .. versionadded:: NEXT.VERSION, .. versionchanged:: NEXT.VERSION, .. deprecated:: NEXT.VERSION or ``.. versionremoved:: NEXT.VERSION` to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • [ ] Added myself alphabetically to AUTHORS.rst (optional)
  • [ ] Added new classes & modules to the docs and all suitable __all__ s
  • Checked the Stability Policy in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage)

  • Checked the Bot API specific sections of the Stability Policy

  • [ ] Created a PR to remove functionality deprecated in the previous Bot API release (see here)

  • New Classes

  • Added New Shortcuts

    • In telegram.Chat & telegram.User for all methods that accept chat/user_id
    • [ ] In telegram.Message for all methods that accept chat_id and message_id
    • [ ] For new telegram.Message shortcuts: Added quote argument if methods accept reply_to_message_id
    • [ ] In telegram.CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
  • If Relevant

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Linked new and existing constants in docstrings instead of hard-coded numbers and strings
    • Added the new method(s) to _extbot.py
    • Added or updated bot_methods.rst
Rest is irrelevant

- [ ] Added new message types to `telegram.Message.effective_attachment`
- [ ] Added new handlers for new update types
    - [ ] Added the handlers to the warning loop in the [`telegram.ext.ConversationHandler`](https://python-telegram-bot.readthedocs.io/en/stable/telegram.ext.conversationhandler.html)
- [ ] Added new filters for new message (sub)types
- [ ] Added or updated documentation for the changed class(es) and/or method(s)
- [ ] Updated the Bot API version number in all places: `README.rst` (including the badge) and `telegram.constants.BOT_API_VERSION_INFO`
- [ ] Added logic for arbitrary callback data in `telegram.ext.ExtBot` for new methods that either accept a `reply_markup` in some form or have a return type that is/contains [`telegram.Message`](https://python-telegram-bot.readthedocs.io/en/stable/telegram.message.html)

@Bibo-Joshi Bibo-Joshi mentioned this pull request Jan 7, 2026
35 tasks
Copy link
Member

@aelkheir aelkheir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor doc suggestion!

# Conflicts:
#	changes/unreleased/5078.FoNwUYLbXQFRebTFhR6UPn.toml
#	src/telegram/_bot.py
#	src/telegram/_chat.py
#	src/telegram/_user.py
#	src/telegram/ext/_extbot.py
#	tests/test_chat.py
#	tests/test_user.py
# Conflicts:
#	changes/unreleased/5078.FoNwUYLbXQFRebTFhR6UPn.toml
@Bibo-Joshi Bibo-Joshi merged commit 5ff5ef1 into api-9.3-central Jan 12, 2026
20 of 27 checks passed
@Bibo-Joshi Bibo-Joshi deleted the api-9.3-get-gifts branch January 12, 2026 17:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants