feat: add Defaults.business_connection_id support #5097

Francluob · 2026-01-08T16:25:08Z

Add business_connection_id parameter to Defaults class
Update all send_* methods to use ODVInput[str] for business_connection_id
This allows setting a default business_connection_id via Defaults mechanism
Follows the same pattern as other defaults like parse_mode and disable_notification

Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=11581451

- Add business_connection_id parameter to Defaults class - Update all send_* methods to use ODVInput[str] for business_connection_id - This allows setting a default business_connection_id via Defaults mechanism - Follows the same pattern as other defaults like parse_mode and disable_notification Closes python-telegram-bot#4193

- Use DefaultValue.get_value() to extract str | None from ODVInput[str] - Fixes type incompatibility when assigning business_connection_id

Francluob · 2026-01-08T17:16:25Z

hello @Bibo-Joshi
could you please review my pr?
thanks

Bibo-Joshi

Hi. Thanks for your PR.
The changes look ok at first glance. However, we'll need unit tests for all modified bot methods ensuring that the defaults values are passed correctly. Please have a look at e.g.

python-telegram-bot/tests/test_bot.py

Lines 2500 to 2523 in 8511941

    
               @pytest.mark.parametrize("default_bot", [{"parse_mode": "Markdown"}], indirect=True) 
        
               @pytest.mark.parametrize( 
        
                   ("passed_value", "expected_value"), 
        
                   [(DEFAULT_NONE, "Markdown"), ("HTML", "HTML"), (None, None)], 
        
               ) 
        
               async def test_gift_premium_subscription_default_parse_mode( 
        
                   self, default_bot, monkeypatch, passed_value, expected_value 
        
               ): 
        
                   # can't make actual request so we just test that the correct data is passed 
        
                   async def make_assertion(url, request_data, *args, **kwargs): 
        
                       assert request_data.parameters.get("text_parse_mode") == expected_value 
        
                       return True 
        
                   monkeypatch.setattr(default_bot.request, "post", make_assertion) 
        
                   kwargs = { 
        
                       "user_id": 123, 
        
                       "month_count": 3, 
        
                       "star_count": 1000, 
        
                       "text": "text", 
        
                   } 
        
                   if passed_value is not DEFAULT_NONE: 
        
                       kwargs["text_parse_mode"] = passed_value 
        
                   assert await default_bot.gift_premium_subscription(**kwargs)

or one of the many other test_*_default_* tests on how they use parametrization for the tests.
Moreover, I'll to put this on ~~hault~~ hold until after #5078 is merged since Bot API 9.3 adds new methods with business_connection_id parameters.

src/telegram/ext/_defaults.py

- Replace hardcoded version number with NEXT.VERSION placeholder - Follows project standard for version documentation

Francluob · 2026-01-09T01:08:43Z

Hi. Thanks for your PR. The changes look ok at first glance. However, we'll need unit tests for all modified bot methods ensuring that the defaults values are passed correctly. Please have a look at e.g.

python-telegram-bot/tests/test_bot.py

Lines 2500 to 2523 in 8511941

@pytest.mark.parametrize("default_bot", [{"parse_mode": "Markdown"}], indirect=True)

@pytest.mark.parametrize(

("passed_value", "expected_value"),

[(DEFAULT_NONE, "Markdown"), ("HTML", "HTML"), (None, None)],

)

async def test_gift_premium_subscription_default_parse_mode(

self, default_bot, monkeypatch, passed_value, expected_value

):

# can't make actual request so we just test that the correct data is passed

async def make_assertion(url, request_data, *args, **kwargs):

assert request_data.parameters.get("text_parse_mode") == expected_value

return True

monkeypatch.setattr(default_bot.request, "post", make_assertion)

kwargs = {

"user_id": 123,

"month_count": 3,

"star_count": 1000,

"text": "text",

}

if passed_value is not DEFAULT_NONE:

kwargs["text_parse_mode"] = passed_value

assert await default_bot.gift_premium_subscription(**kwargs)

or one of the many other test_*_default_* tests on how they use parametrization for the tests. Moreover, I'll to put this on hault until after #5078 is merged since Bot API 9.3 adds new methods with business_connection_id parameters.

sounds fair, please ping me when you merge #5078

Bibo-Joshi · 2026-01-09T09:03:00Z

@Francluob you can subscribe to the PR, then you'll be notified :)

Francluob added 2 commits January 8, 2026 17:23

Fix mypy error: Extract value from ODVInput in Message.__init__

77697bc

- Use DefaultValue.get_value() to extract str | None from ODVInput[str] - Fixes type incompatibility when assigning business_connection_id

Bibo-Joshi requested changes Jan 8, 2026

View reviewed changes

src/telegram/ext/_defaults.py Outdated Show resolved Hide resolved

Use NEXT.VERSION placeholder for business_connection_id versionadded

32e33cb

- Replace hardcoded version number with NEXT.VERSION placeholder - Follows project standard for version documentation

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add Defaults.business_connection_id support #5097

feat: add Defaults.business_connection_id support #5097

Francluob commented Jan 8, 2026

Uh oh!

Francluob commented Jan 8, 2026

Uh oh!

Bibo-Joshi left a comment •

edited

Loading

Uh oh!

Uh oh!

Francluob commented Jan 9, 2026

Uh oh!

Bibo-Joshi commented Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	@pytest.mark.parametrize("default_bot", [{"parse_mode": "Markdown"}], indirect=True)
	@pytest.mark.parametrize(
	("passed_value", "expected_value"),
	[(DEFAULT_NONE, "Markdown"), ("HTML", "HTML"), (None, None)],
	)
	async def test_gift_premium_subscription_default_parse_mode(
	self, default_bot, monkeypatch, passed_value, expected_value
	):
	# can't make actual request so we just test that the correct data is passed
	async def make_assertion(url, request_data, args, *kwargs):
	assert request_data.parameters.get("text_parse_mode") == expected_value
	return True

	monkeypatch.setattr(default_bot.request, "post", make_assertion)
	kwargs = {
	"user_id": 123,
	"month_count": 3,
	"star_count": 1000,
	"text": "text",
	}
	if passed_value is not DEFAULT_NONE:
	kwargs["text_parse_mode"] = passed_value

	assert await default_bot.gift_premium_subscription(**kwargs)

feat: add Defaults.business_connection_id support #5097

Are you sure you want to change the base?

feat: add Defaults.business_connection_id support #5097

Conversation

Francluob commented Jan 8, 2026

Uh oh!

Francluob commented Jan 8, 2026

Uh oh!

Bibo-Joshi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Francluob commented Jan 9, 2026

Uh oh!

Bibo-Joshi commented Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Bibo-Joshi left a comment •

edited

Loading