Settings experience optimization#341
Merged
quoid merged 5 commits intoquoid:developfrom Oct 10, 2022
ACTCD:settings-experience-optimization
Merged
Settings experience optimization#341quoid merged 5 commits intoquoid:developfrom ACTCD:settings-experience-optimization
quoid merged 5 commits intoquoid:developfrom
ACTCD:settings-experience-optimization
Conversation
Owner
|
@ACTCD wouldn't changing click to mousedown or mouseup correct this issue without the need for more html? <div
class="settings"
on:mousedown|self={() => state.remove("settings")}
in:fade={{duration: 150}}
out:fade={{duration: 150, delay: 75}}
>
|
Co-authored-by: quoid <justin@emlxl.com>
Collaborator
Author
|
@quoid Yes, you are right, we can simply use |
quoid
added a commit
that referenced
this pull request
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the changes from #339 and adds a new fix:
click-to-close.mp4
click-to-close-fix.mp4