refactor: use light-dark for console log colors#833
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the previous JavaScript-based dark-mode color logic for console logs with a static mapping that uses the CSS light-dark() function.
- Removed the
getColorfunction and media-query listener in favor of acolorsconstant - Updated all
console.infocalls to import and use the newcolorsmapping
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/shared/colors.js | Swapped dynamic getColor() logic for a static export const colors using light-dark() |
| src/ext/content-scripts/entry-userscripts.js | Updated imports and all console.* calls to reference the new colors entries |
Comments suppressed due to low confidence (1)
src/shared/colors.js:5
- Consider adding a unit test for the
colorsmapping to verify each key produces the expected CSS string for console styling.
export const colors = {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried using
light-dark()while doing #828, but I don't know why it didn't work at that time.Anyway, try checking this again and it works, so replace it.