Skip to content

Comments

sticky-sidebar - Restore on PR conversation page#8979

Open
SunsetTechuila wants to merge 5 commits intomainfrom
sticky-sidebar
Open

sticky-sidebar - Restore on PR conversation page#8979
SunsetTechuila wants to merge 5 commits intomainfrom
sticky-sidebar

Conversation

@SunsetTechuila
Copy link
Member

@SunsetTechuila SunsetTechuila commented Feb 14, 2026

@@ -27,26 +20,15 @@ Exclusively use simple sums and use `0px` instead of `0`
/* It needs to be on the same element as above for calc() to work */
--rgh-sticky-notification-header-height: 69px;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use --base-sticky-header-height GH variable. sticky-comment-header already does

[id^='my-forks-menu'] {
z-index: initial !important; /* This affects the social buttons. It seems to have no effect but it constantly causes trouble with other features. */
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated

Comment on lines 45 to 48
/* Hides the last divider (on pull requests) to avoid https://user-images.githubusercontent.com/10238474/62282128-af6fb980-b457-11e9-8b18-c29687b88da1.gif */
.rgh-sticky-sidebar + .border-top {
display: none;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated

Comment on lines -31 to -34
/* required to make `sticky` work for the issue Sidebar */
.rgh-sticky-sidebar-container {
display: unset !important;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated

'.Layout-sidebar #partial-discussion-sidebar', // Old `isConversation`
'div[data-testid="issue-viewer-metadata-pane"]', // `isConversation`
'#discussion_bucket #partial-discussion-sidebar', // `isDiscussion`
'div[data-testid="issue-viewer-metadata-pane"]', // Issue `isConversation`. TODO: Remove after March 2026
Copy link
Member Author

@SunsetTechuila SunsetTechuila Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue sidebar is natively sticky for at least 5 months: #8696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant