Greptile Overview

Greptile Summary

This PR fixes dynamic routes with periods (e.g., /data/v1.2.3/info) breaking in production mode by adding sirv --ignores flags to exclude dynamic route prefixes from asset detection.

Key Changes:

• Added get_dynamic_route_prefixes() in reflex/route.py:135 to extract route patterns with dynamic segments
• Updated _compile_package_json() in reflex/utils/frontend_skeleton.py:170 to build sirv command with --ignores flags
• Wired route collection in reflex/app.py:1540 during compilation to generate and pass dynamic route prefixes

Issues Found:

• The catchall pattern detection in reflex/route.py:161-165 is incomplete - missing checks for STRICT_CATCHALL ([...slug]) and OPTIONAL_CATCHALL ([[...slug]]) patterns, only checking for the literal "[[...splat]]" string

Confidence Score: 4/5

• This PR is safe to merge after fixing the catchall pattern detection
• The implementation correctly solves the stated problem of periods in dynamic routes, and the approach of using sirv --ignores is sound. However, there's a logical bug where catchall route patterns ([...slug] and [[...slug]]) won't be properly detected, meaning routes using those patterns may still break. The fix is straightforward - add the missing regex checks.
• Pay close attention to reflex/route.py - the catchall pattern logic needs to be fixed before merging

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant App as App.compile()
    participant Route as route.get_dynamic_route_prefixes()
    participant Skeleton as frontend_skeleton.initialize_package_json()
    participant PackageJson as package.json

    App->>App: Collect routes from _unevaluated_pages
    App->>Route: get_dynamic_route_prefixes(routes)
    Route->>Route: Filter routes with dynamic segments
    Route->>Route: Extract prefix before first dynamic segment
    Route-->>App: Return list of prefixes (e.g., ["^/data/", "^/posts/"])
    
    alt dynamic_route_prefixes exist
        App->>Skeleton: initialize_package_json(dynamic_route_prefixes)
        Skeleton->>Skeleton: Build sirv command with --ignores flags
        Skeleton->>PackageJson: Write package.json with updated prod command
    end

is this even a bug anymore? on current main:

import reflex as rx


def index():
    return rx.heading(rx.State.id, rx.State.version, rx.State.slug)


app = rx.App()
app.add_page(index, route="/foo/[id]/[version]/[slug]")
app.add_page(index, route="/data/[version]/info")
app.add_page(index, route="/posts/[slug]")
app.add_page(index, route="/[id]")
app.add_page(index)

all of /data/v1.2.3/info and various combinations of periods are rendering correctly. the /[id] one does not work with periods, but that's probably okay.

maybe the bug got fixed upstream?

either way, when i run with the --ignores arguments from this PR, the routes below them don't seem to render at all