use get_event_handler in upload, cherry-pick from #6100#6130
Merged
masenf merged 1 commit intoreflex-dev:mainfrom Feb 12, 2026
Merged
Conversation
Contributor
Greptile OverviewGreptile SummaryRefactored event handler retrieval logic by moving Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant App
participant State
participant StateProxy
Note over App,State: Upload Handler Flow
Client->>App: Upload request with handler name
App->>State: _get_event_handler(handler_string)
State->>State: Parse handler path
State->>State: Get substate and handler
State-->>App: Return (substate, event_handler)
App->>App: Check if background task
alt is background task
App->>App: Raise UploadTypeError
else not background task
App->>App: Process upload with handler.fn
end
Note over App,StateProxy: Background Task Flow
Client->>App: Event request
App->>State: _get_event_handler(event)
State->>State: Parse event.name
State->>State: Get substate and handler
State-->>App: Return (substate, handler)
App->>App: Check if background task
alt is background task
App->>StateProxy: Wrap substate in StateProxy
StateProxy->>StateProxy: Create async task
else not background task
App->>State: Process event normally
end
|
masenf
reviewed
Feb 12, 2026
Collaborator
masenf
left a comment
There was a problem hiding this comment.
thanks for splitting this out. looking good
masenf
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.