Conversation
30cc968 to
a4c2681
Compare
The `output` variable is shadowed by the yielding loop, so when we hit
the line:
previous_output = output
the value of `output` refers to the last value of `output` from the loop
above, not the total output we received. That causes the client to
shrink the output down to a single string (which, inconveniently, also
is a valid argument to `len()`), which means we take the wrong slice of
the output the next time through the loop.
Signed-off-by: Dominic Baggott <dominic.baggott@gmail.com>
a4c2681 to
2cfc397
Compare
mattt
approved these changes
May 23, 2023
This was referenced May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
outputvariable is shadowed by the yielding loop, so when we hit the line:the value of
outputrefers to the last value ofoutputfrom the loop above, not the total output we received. That causes the client to shrink the output down to a single string (which, inconveniently, also is a valid argument tolen()), which means we take the wrong slice of the output the next time through the loop.