Merged
Conversation
Refs replicate#112 Signed-off-by: Simon Willison <swillison@gmail.com>
This was referenced Jul 18, 2023
mattt
approved these changes
Jul 19, 2023
Contributor
There was a problem hiding this comment.
Thanks so much for your PR, @simonw! And thanks for building a Replicate plugin for llm.
I wasn't aware of the Pydantic 2 having a v1 shim, so that's really helpful. I merged #113 as stopgap measure, but hadn't circled back to implement a proper fix.
A linting error was blocking this from getting merged, so I applied a change to fix that.
Contributor
|
This is now available in version 0.9.0. Thanks again for your help, @simonw! |
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs:
My LLM project uses Pydantic 2 and I want to build a plugin for it (llm-replicate) that adds support for querying Replicate models - but I can't do that easily if Replicate is pinned to Pydantic 1.0.
It looks like it's possible to support both using this idiom:
Since 2.0 introduced a
v1backwards compatibility shim.