#9 에서 잘못 오픈한 액세스 지시자 수정 #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyungtae-TEI
reviewed
Jan 3, 2023
| fileprivate weak var webView: WKWebView? | ||
|
|
||
| open var bridges = [MethodBridge]() | ||
| open private(set) var bridges = [MethodBridge]() |
There was a problem hiding this comment.
#9 에서 같이 수정되었던 jsSelector, argumentCount는 외부에서 수정가능해도 되나요??
There was a problem hiding this comment.
jsSelector, argumentCount는 computed property인데 이건 read-only 속성을 가지고 있습니다!
Kyungtae-TEI
approved these changes
Jan 3, 2023
jiggag
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
bridges프로퍼티를 외부에서 수정할 수 없도록 수정 했습니다.