This repository was archived by the owner on Feb 24, 2020. It is now read-only.
config: add tests for a couple documented configs#3931
Open
euank wants to merge 7 commits intorkt:masterfrom
Open
config: add tests for a couple documented configs#3931euank wants to merge 7 commits intorkt:masterfrom
euank wants to merge 7 commits intorkt:masterfrom
Conversation
This tests that a small number of the documented configurations suggested can in fact unmarshal without error.
The Golang team only officially supports the two most recent major versions. At the very least, we can safely drop 1.6.x and add 1.10.x
Member
Author
|
Semaphore appears to be flaking on a networking issue unrelated to this pr: Sounds like an nftables kernel module is missing? |
Member
|
@euank is that a single flake or does it persist across retries? |
Member
Author
|
I've seen it twice in a row now. I don't have permissions on the rkt semaphore to poke around too much though. |
In go 1.10, 'go vet' complains about unkeyed fields. This makes go vet happy.
Member
|
@euank it looks like you were missing from the semaphore team, added you now. |
Before, the contents of the error were lost in that path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests additions were prompted by issue #3916.
Ideally all documented configs would be included here (possibly via living outside of the docs and having the copy in the docs be templated in or such).