Match object with value passed to the function#117
Closed
mitogh wants to merge 1 commit intoryanmcdermott:masterfrom
mitogh:master
Closed
Match object with value passed to the function#117mitogh wants to merge 1 commit intoryanmcdermott:masterfrom mitogh:master
mitogh wants to merge 1 commit intoryanmcdermott:masterfrom
mitogh:master
Conversation
The object passed to the function was not using the same name.
Contributor
|
This was changed intentionally in #97 |
Owner
|
Hey Crisoforo! Thank you for contributing. As Vse stated, this has been changed back and forth. Let's settle on what's currently there, because at some point in the future someone might want to change it back! |
Contributor
Author
|
Sounds good thanks @vsemozhetbyt @ryanmcdermott |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The object passed to the function was not using the same name and it was a little bit confusing since on the
Goodexample was using a not defined variable.