Fix ValueError in KNeighborsClassifier with brute force and p=1 #33048
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #33034
What does this implement/fix? Explain your changes.
When using
KNeighborsClassifierwithalgorithm="brute"andp=1(Manhattan distance), the code path utilizesArgKminClassMode. Previously,self.classes_(which can contain strings) was passed directly to theunique_Y_labelsargument of the Cython method, causing aValueErrorwhen it attempted to interpret strings as integers.I have updated the call to pass
np.arange(len(self.classes_), dtype=np.intp)instead, which provides the correct integer indices expected by the underlying Cython implementation.Any other comments?
Added a regression test case in
sklearn/neighbors/tests/test_neighbors.py.