Skip to content

refactor helpers using property getter/setter #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SendGridDX merged 3 commits into from
Apr 5, 2017
Merged

refactor helpers using property getter/setter #244

SendGridDX merged 3 commits into from
Apr 5, 2017

Conversation

@denis90
Copy link
Contributor

@denis90 denis90 commented Nov 1, 2016

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: cla signed status: work in progress Twilio or the community is in the process of implementing labels Nov 8, 2016
@SendGridDX
Copy link

SendGridDX commented Mar 31, 2017

Hello @denis90,

This one finally bubbled up to the top of our queue. I see there are few conflicts, could you please resolve them?

Thanks!

Elmer

@SendGridDX
Copy link

SendGridDX commented Mar 31, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@denis90
Copy link
Contributor Author

denis90 commented Mar 31, 2017

resolved conflicts

@SendGridDX SendGridDX merged commit 8b11b6e into sendgrid:master Apr 5, 2017
@SendGridDX
Copy link

SendGridDX commented Apr 5, 2017

Hello @denis90,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

thinkingserious added a commit that referenced this pull request Apr 5, 2017
@thinkingserious
Version Bump v4.0.0: BREAKING CHANGE #244
65943e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@denis90 @SendGridDX @thinkingserious