-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(agent-tools): added special handling for workflow tool in agent tool input, added react grab and feature flag #2820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ool input, added react grab
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryAdded React Grab debugging tool integration, workflow tool icon rendering, and combobox search query clearing. The PR introduces a feature-flagged React Grab integration for UI debugging in development environments, adds visual support for workflow tools with proper icon rendering, and fixes a UX issue where search queries persisted when reopening the combobox. Key Changes:
Issues Found:
Confidence Score: 2/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Layout
participant FeatureFlags
participant ToolInput
participant Combobox
User->>Layout: Load application
Layout->>FeatureFlags: Check isReactGrabEnabled
alt isDev && REACT_GRAB_ENABLED
FeatureFlags-->>Layout: true
Layout->>Layout: Load React Grab scripts from unpkg
else
FeatureFlags-->>Layout: false
Layout->>Layout: Skip React Grab scripts
end
User->>ToolInput: Select workflow tool
ToolInput->>ToolInput: Set isWorkflowTool = true
ToolInput->>ToolInput: Render WorkflowIcon with #6366F1 color
Note over ToolInput: BUG: Missing !isWorkflowTool checks<br/>in getToolIdForOperation,<br/>getToolParametersConfig, etc.
User->>Combobox: Open dropdown
User->>Combobox: Search for options
User->>Combobox: Select option
Combobox->>Combobox: Close dropdown
Combobox->>Combobox: Clear search query
User->>Combobox: Reopen dropdown
Note over Combobox: Search query is now empty
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, 2 comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (4)
-
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx, line 2208-2211 (link)logic: Missing
!isWorkflowToolcheck. Workflow tools will incorrectly callgetToolIdForOperationwhich is meant for standard tools. -
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx, line 2214-2217 (link)logic: Missing
!isWorkflowToolcheck. Workflow tools will incorrectly attempt to fetch tool parameters config. -
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx, line 2275 (link)logic: Missing
!isWorkflowToolcheck. Workflow tools will incorrectly be checked for multiple operations. -
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/tool-input/tool-input.tsx, line 2269-2272 (link)logic: Missing
!isWorkflowToolchecks. Workflow tools will incorrectly be processed as standard tools in these conditionals.
5 files reviewed, 4 comments
Summary
Type of Change
Testing
Tested manually
Checklist