-
Notifications
You must be signed in to change notification settings - Fork 3.2k
improvement(serializer): canonical subblock, serialization cleanups #2848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR consolidates preprocessing checks and refactors the serializer/validation logic across async execution paths. The main improvements are:
All changes maintain backward compatibility and improve code maintainability by centralizing cross-cutting concerns. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant API as API Route
participant Preprocess as Preprocessing
participant Preflight as Env Preflight
participant Execution as Schedule Execution
participant Logger as Logger
Client->>API: Trigger Workflow Execution
API->>Preprocess: preprocessExecution({preflightEnvVars: true})
Preprocess->>Logger: Validate Workflow Exists
Preprocess->>Logger: Check Deployment Status
Preprocess->>Logger: Resolve Billing Actor
Preprocess->>Logger: Get User Subscription
Preprocess->>Logger: Check Rate Limits
Preprocess->>Logger: Check Usage Limits
Preprocess->>Preflight: await preflightWorkflowEnvVars()
alt Preflight Success
Preflight-->>Preprocess: Return Success
Preprocess-->>API: Return {success: true}
else Preflight Fails
Preflight-->>Logger: Log Error
Preprocess-->>API: Return {success: false, error}
end
API->>Execution: handleAsyncExecution({preflighted: true})
Execution->>Logger: Execute Workflow Core (skip preflight)
Execution-->>Client: Return Execution Result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
44 files reviewed, 1 comment
…block # Conflicts: # apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/sub-block.tsx
Summary
Type of Change
Testing
Tested manually
Checklist