Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • Add genericOAuth provider IDs (google-email, google-calendar, microsoft-teams, etc.) to trustedProviders list
  • Fixes "unable_to_link_account" error when connecting Gmail and other OAuth integrations

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Jan 22, 2026 6:43am

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 22, 2026

Greptile Summary

This PR fixes the "unable_to_link_account" error when connecting OAuth integrations by adding genericOAuth provider IDs to the trustedProviders list in the account linking configuration.

  • Added 23 provider IDs for Google services (google-email, google-calendar, google-drive, etc.), Microsoft services (microsoft-teams, outlook, onedrive, etc.), and other integrations (jira, airtable, dropbox, salesforce, zoom, wordpress)
  • All added provider IDs correspond to existing genericOAuth configurations defined in the same file
  • No functional changes beyond expanding the trusted providers list

Confidence Score: 5/5

  • This PR is safe to merge - it only adds string values to an existing configuration array
  • Simple, low-risk change that adds missing provider IDs to an existing list. All added providers are already configured as genericOAuth providers in the codebase. No logic changes, no new dependencies, and the fix directly addresses the reported "unable_to_link_account" error.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/lib/auth/auth.ts Added 23 genericOAuth provider IDs to trustedProviders list to enable account linking for integrations like Gmail, Google Calendar, Microsoft Teams, etc. All added providers match existing genericOAuth configurations.

Sequence Diagram

sequenceDiagram
    participant U as User
    participant A as App
    participant B as Auth
    participant P as Provider
    U->>A: Connect integration
    A->>B: Start OAuth
    B->>P: Redirect
    P-->>B: Code returned
    B->>B: Check trustedProviders
    B-->>A: Link account
    A-->>U: Connected
Loading

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@waleedlatif1 waleedlatif1 merged commit 376f7cb into staging Jan 22, 2026
4 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/gmail branch January 22, 2026 06:44
waleedlatif1 added a commit that referenced this pull request Jan 22, 2026
* fix(zustand): updated to useShallow from deprecated createWithEqualityFn (#2919)

* fix(logger): use direct env access for webpack inlining (#2920)

* fix(notifications): text overflow with line-clamp (#2921)

* chore(helm): add env vars for Vertex AI, orgs, and telemetry (#2922)

* fix(auth): improve reset password flow and consolidate brand detection (#2924)

* fix(auth): improve reset password flow and consolidate brand detection

* fix(auth): set errorHandled for EMAIL_NOT_VERIFIED to prevent duplicate error

* fix(auth): clear success message on login errors

* chore(auth): fix import order per lint

* fix(action-bar): duplicate subflows with children (#2923)

* fix(action-bar): duplicate subflows with children

* fix(action-bar): add validateTriggerPaste for subflow duplicate

* fix(resolver): agent response format, input formats, root level (#2925)

* fix(resolvers): agent response format, input formats, root level

* fix response block initial seeding

* fix tests

* fix(messages-input): fix cursor alignment and auto-resize with overlay (#2926)

* fix(messages-input): fix cursor alignment and auto-resize with overlay

* fixed remaining zustand warnings

* fix(stores): remove dead code causing log spam on startup (#2927)

* fix(stores): remove dead code causing log spam on startup

* fix(stores): replace custom tools zustand store with react query cache

* improvement(ui): use BrandedButton and BrandedLink components (#2930)

- Refactor auth forms to use BrandedButton component
- Add BrandedLink component for changelog page
- Reduce code duplication in login, signup, reset-password forms
- Update star count default value

* fix(custom-tools): remove unsafe title fallback in getCustomTool (#2929)

* fix(custom-tools): remove unsafe title fallback in getCustomTool

* fix(custom-tools): restore title fallback in getCustomTool lookup

Custom tools are referenced by title (custom_${title}), not database ID.
The title fallback is required for client-side tool resolution to work.

* fix(null-bodies): empty bodies handling (#2931)

* fix(null-statuses): empty bodies handling

* address bugbot comment

* fix(token-refresh): microsoft, notion, x, linear (#2933)

* fix(microsoft): proactive refresh needed

* fix(x): missing token refresh flag

* notion and linear missing flag too

* address bugbot comment

* fix(auth): handle EMAIL_NOT_VERIFIED in onError callback (#2932)

* fix(auth): handle EMAIL_NOT_VERIFIED in onError callback

* refactor(auth): extract redirectToVerify helper to reduce duplication

* fix(workflow-selector): use dedicated selector for workflow dropdown (#2934)

* feat(workflow-block): preview (#2935)

* improvement(copilot): tool configs to show nested props (#2936)

* fix(auth): add genericOAuth providers to trustedProviders (#2937)

---------

Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com>
Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants