Open
Conversation
rlvoyer
requested changes
Jan 25, 2022
Contributor
rlvoyer
left a comment
There was a problem hiding this comment.
Looks pretty good. Left a few suggestion.
| def publish_to_pypi(repository): | ||
| """ | ||
| Publish the distribution to our local PyPi. | ||
| :param repository: the repository to be used by the ReleaseCommand for the artifact upload. If ommitted, repository will be defaulted to PyPi |
Contributor
There was a problem hiding this comment.
We use the style specified here.
So this should be
"""
Args:
repository: the repository to be uploaded to (eg. Artifactory or Pypi.org).
"""| :param repository: the repository to be used by the ReleaseCommand for the artifact upload. If ommitted, repository will be defaulted to PyPi | ||
| """ | ||
| code = Popen(["twine", "upload", "dist/*", "-r", "artifactory"]).wait() | ||
| cmd = None |
Contributor
There was a problem hiding this comment.
Nit: it would be slightly simpler as follows:
if repository is None:
repository = "pypy"
cmd = ["twine", "upload", "dist/*", "--repository", repository]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating pull request, for parameterizing respository name instead of hard-coding to artifactory