Open
Conversation
added 9 commits
December 21, 2021 16:52
rlvoyer
requested changes
Jan 25, 2022
Contributor
rlvoyer
left a comment
There was a problem hiding this comment.
Good change. Left some comments for things to cleanup.
| @@ -0,0 +1,336 @@ | |||
| """ | |||
Contributor
There was a problem hiding this comment.
This file looks like an accident. Please remove.
| except exceptions.TwineException as exc: | ||
| result = f"{exc.__class__.__name__}: {exc.args[0]}" | ||
| raise RuntimeError("Error publishing to PyPi", exc) | ||
| code = 0 |
Contributor
There was a problem hiding this comment.
code is now unused. Please remove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the Popen call to invoke twine using the cli instead as a sub-process