Added convenience function to extract SPDX elements by their Id#531
Merged
armintaenzertng merged 1 commit intospdx:refactor-python-toolsfrom Mar 24, 2023
Merged
Conversation
2a18110 to
bc60bc9
Compare
Collaborator
armintaenzertng
left a comment
There was a problem hiding this comment.
Thanks for your contribution! :)
If you like, you can also include a unit test for this under tests/spdx/test_document_utils.py. If not, I'm happy to include it after this PR is merged.
| element_ids.extend([package.spdx_id for package in document.packages]) | ||
| element_ids.extend([snippet.spdx_id for snippet in document.snippets]) | ||
| return element_ids | ||
| def get_element_from_spdx_id(document: Document, spdx_id: str) -> Union[Package, File, Snippet, None]: |
Collaborator
There was a problem hiding this comment.
PEP8 requires two blank lines between methods.
Which IDE are you using for your python development? There might be a plugin for your IDE to detect PEP8 violations.
34b8bc8 to
ecca0da
Compare
Signed-off-by: HarshvMahawar <hv062727@gmail.com>
ecca0da to
d27bbe1
Compare
armintaenzertng
approved these changes
Mar 24, 2023
Collaborator
armintaenzertng
left a comment
There was a problem hiding this comment.
Thanks, looks good! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.