Conversation
rousskov
left a comment
There was a problem hiding this comment.
Thank you for fixing these. What tool did you use to detect them? Did you have to do any manual processing to correct that tool mistakes?
I usually use cspell, but it has many false positives, so you end up having to sift through them all. |
Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
|
@rousskov Although some of these suggestions were not misspells, I went ahead and applied them all [and updated the PR info]. Let me know if anything else needs a fix. |
There was a problem hiding this comment.
Almost done AFAICT, provided others are OK with removing contractions as tracked in a dedicated change request.
| doesn't recycle those pages too quickly. Grr\! | ||
| - Still, even at 10,000 req/sec with an average logging line length of | ||
| 160 characters thats 1.52 megabytes a second of data to copy; not | ||
| 160 characters that's 1.52 megabytes a second of data to copy; not |
There was a problem hiding this comment.
| 160 characters that's 1.52 megabytes a second of data to copy; not | |
| 160 characters that is 1.52 megabytes a second of data to copy; not |
| Authentication | ||
|
|
||
| # What's the legal status of Squid? | ||
| # What is the legal status of Squid? |
There was a problem hiding this comment.
Although some of these suggestions were not misspells, I went ahead and applied them all
I did not mean to ask you to remove existing correct contractions. My comment was only about PR changes that added or changed contractions. Sorry for not being clear.
FWIW, I am not against removing existing/correct contractions (as this PR now does), but I certainly do not insist on it, and others may not like that idea.
|
|
||
| - Make sure you've got the debugging libraries and library symbols | ||
| installed - under Ubuntu thats 'libc6-dbg'. | ||
| installed - under Ubuntu that's 'libc6-dbg'. |
There was a problem hiding this comment.
| installed - under Ubuntu that's 'libc6-dbg'. | |
| installed - under Ubuntu that is 'libc6-dbg'. |
|
|
||
| Then Squid opens a TCP connection to the destination host and port, and | ||
| the *real* request is sent encrypted over this connection. Thats the | ||
| the *real* request is sent encrypted over this connection. That's the |
There was a problem hiding this comment.
| the *real* request is sent encrypted over this connection. That's the | |
| the *real* request is sent encrypted over this connection. That is the |
| # Another Client Side? | ||
|
|
||
| Or, "a new HTTP server side", as thats what it is. | ||
| Or, "a new HTTP server side", as that's what it is. |
There was a problem hiding this comment.
| Or, "a new HTTP server side", as that's what it is. | |
| Or, "a new HTTP server side", as that is what it is. |
| - HTTP authentication? Or could that be implemented between the HTTP | ||
| network server and the HTTP request queue? | ||
| - SSL. Thats a connection property. | ||
| - SSL. That's a connection property. |
There was a problem hiding this comment.
| - SSL. That's a connection property. | |
| - SSL. That is a connection property. |
yadij
left a comment
There was a problem hiding this comment.
Given the touched lines a look over.
Please add "cacheable" to your dictionary. It is one of the weird exceptional words that does not follow the rule in English about dropping the 'e' suffix - something about how Americans pronouce 'a-ch-a' sounds differently from English.
Quite a lot of inconsistency in contraction handling, IMO it should be done. Progress is still progress though, so I am good as long as the touched lines are correct.
Two major issues to decide:
-
when text is quoting a discussion. To expand contractions or not?
-
when typo is in the page/file name. To rename the file or not?
- i.e. KnowledgeBase/UnparseableHeader.md - should be UnparsableHeader
| 11. the client | ||
|
|
||
| ## Uncacheable request | ||
| ## Uncacheble request |
There was a problem hiding this comment.
original word was correct spelling.
| ## Uncacheble request | |
| ## Uncacheable request |
| ## Tunnel request | ||
|
|
||
| ## Cachable request | ||
| ## Cacheble request |
There was a problem hiding this comment.
Original word was wrong, but so is the replacement.
| ## Cacheble request | |
| ## Cacheable request |
| used (and reloaded if/when needed). Data pages are also discarded if | ||
| unmodified, and paged out if there's been any changes. Allocated memory | ||
| (malloc) is always saved to disk since there's no executable file to | ||
| unmodified, and paged out if there has been any changes. Allocated memory |
There was a problem hiding this comment.
temporal plural. has/have
| unmodified, and paged out if there has been any changes. Allocated memory | |
| unmodified, and paged out if there have been any changes. Allocated memory |
| ## FAQ about this report | ||
|
|
||
| ### What's the difference between a hit, a negative hit and a miss? | ||
| ### i the difference between a hit, a negative hit and a miss? |
There was a problem hiding this comment.
manual typo?
| ### i the difference between a hit, a negative hit and a miss? | |
| ### What is the difference between a hit, a negative hit and a miss? |
| there can be benefit from enabling this in accelerator setups where the | ||
| web servers are the bottleneck but are reliable and return mostly | ||
| cacheable information. | ||
| cachable information. |
There was a problem hiding this comment.
original was correct
| cachable information. | |
| cacheable information. |
| disk storage, otherwise processing will be done in RAM. | ||
| exclude_types | ||
| List of semicolon seprated MIME types which shouldn't be | ||
| List of semicolon separated MIME types which shouldn't be |
There was a problem hiding this comment.
contraction
| List of semicolon separated MIME types which shouldn't be | |
| List of semicolon separated MIME types which should not be |
| logdata("MISS",$url,$fname); | ||
| $fileptr=fopen($fname,"w"); | ||
| //no validity check, simply don't write the file if we can't open it. prevents noticeable failure/ | ||
| //no validity check, simply don't write the file if we cannot open it. prevents noticeable failure/ |
There was a problem hiding this comment.
contraction
| //no validity check, simply don't write the file if we cannot open it. prevents noticeable failure/ | |
| //no validity check, simply do not write the file if we cannot open it. prevents noticeable failure/ |
|
|
||
| Since the configuration options in the web interface have moved between | ||
| version 5.x and 6.x I won't describe the exact path. If you don't know | ||
| version 5.x and 6.x I will not describe the exact path. If you don't know |
There was a problem hiding this comment.
contraction
| version 5.x and 6.x I will not describe the exact path. If you don't know | |
| version 5.x and 6.x I will not describe the exact path. If you do not know |
| @@ -130,7 +130,7 @@ organised... | |||
| 15:25 < lifeless> and likewise for the Detach static method | |||
| 15:26 < lifeless> is this making sense ? | |||
| 15:27 < nicholas> yes, but just let me reread a litt.e | |||
There was a problem hiding this comment.
typo
| 15:27 < nicholas> yes, but just let me reread a litt.e | |
| 15:27 < nicholas> yes, but just let me reread a little |
|
|
||
| ```irc | ||
| 14:48 < nicholas> Hi. I'm working on bug 1160 (analyze HTML to prefetch embedded objects). I can't figure out why, but even though it | ||
| 14:48 < nicholas> Hi. I'm working on bug 1160 (analyze HTML to prefetch embedded objects). I cannot figure out why, but even though it |
There was a problem hiding this comment.
I'm not sure we should be fixing contractions when quoting a discussion. In either case the change has been applied inconsistently to this file. Some 's and 't suffix have been expanded and many have not - across lines both touched by other change, and not.
I have also asked to undo changes from "cachable" to "cacheable", but I am not sure that request had the desired effect. Ideally, we should standardize on one spelling; "cachable" spelling is arguably prevalent in primary Squid sources (~124:52). We do not have to standardize in this PR though.
IMHO, we should apply all the automated style/grammar/etc. rules to those discussions because those discussions are illustrations and documentation rather than copies of transcripts that must be preserved in their original form. We can add a "chat transcripts edited for clarity" or a similar disclaimer somewhere if really needed. I bet that most of those discussions should be removed as no longer helpful, but that would be a manual change that deserves dedicated study (and PRs).
Rename -- if the problem can be fixed, it should be. If (and only if) we really want to keep some old links working (for a while), we can handle that on a case-by-base basis using HTTP redirection. I bet the number of cases where such redirects would be justified close to zero. FWIW, changing section titles breaks existing links as well. |
... and avoid using contractions to improve readability.