refactor!: Rename action to publish-image-index-manifest#72
Merged
Conversation
NickLarsenNZ
previously approved these changes
Aug 28, 2025
Member
NickLarsenNZ
left a comment
There was a problem hiding this comment.
It was with intent that I suffixed those with "manifest", because they are, by the specs definition of manifest.
But, if you need it to match the spec, I guess go for it, but it makes me uncomfortable and I think it is an unnecessary change.
Member
Author
|
Man, I hate everything about this. The spec is a joke. I will revert the rename (and opt for a better action name: |
77a6548 to
d80faca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official terms are:
See the spec.
flowchart TB ii[" sdp/kafka:1.2.3-stackable25.7.0 (Image Index Manifest)"] im-1[" sdp/kafka:1.2.3-stackable25.7.0-amd64 (Image Manifest)"] im-2[" sdp/kafka:1.2.3-stackable25.7.0-arm64 (Image Manifest)"] ii -- contains --> im-1 ii -- contains --> im-2