Merged
Conversation
@choojs/findup is a fork of findup that removes the `colors` dependency. `colors` adds lots of properties to the String prototype, which was causing big slowdowns in bankai. About 300ms was spent calling `colors` getters that were never expected to be there (mostly by clean-css).
goto-bus-stop
added a commit
to goto-bus-stop/glslify-deps
that referenced
this pull request
May 30, 2018
@choojs/findup is a fork of findup that removes the `colors` dependency. `colors` adds lots of properties to the String prototype, which can cause problems in other modules that don't expect them to be there. This was causing big slowdowns in [bankai](https://github.com/choojs/bankai). About 300ms was spent calling `colors` getters that were never expected to be there.  Ref choojs/bankai#465 Ref stackcss/sheetify#153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@choojs/findup is a fork of findup that removes the
colorsdependency.colorsadds lots of properties to the String prototype, which wascausing big slowdowns in bankai. About 300ms was spent calling
colorsgetters that were never expected to be there (mostly by the CSS parser).