Skip to content

Handle new Bublé template string compilation. #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goto-bus-stop merged 1 commit into from
Jun 27, 2018
Merged

Handle new Bublé template string compilation. #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"dependencies": {
"@choojs/findup": "^0.2.0",
"acorn-node": "^1.3.0",
"estree-is-member-expression": "^1.0.0",
"fast-json-parse": "^1.0.2",
"insert-css": "^2.0.0",
"map-limit": "0.0.1",
Expand Down
32 changes: 26 additions & 6 deletions transform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
const isMemberExpression = require('estree-is-member-expression')
const cssResolve = require('style-resolve').sync
const transformAst = require('transform-ast')
const staticEval = require('static-eval')
Expand All @@ -18,6 +19,13 @@ function isBabelTemplateDefinition (node) {
node.callee.type === 'Identifier' && node.callee.name === '_taggedTemplateLiteral'
}

function isBubleTemplateDefinition (node) {
return node.type === 'CallExpression' &&
isMemberExpression(node.callee, 'Object.freeze') &&
node.arguments[0] && node.arguments[0].type === 'ArrayExpression' &&
node.arguments[0].elements.every(function (el) { return el.type === 'Literal' })
}

// inline sheetify transform for browserify
// obj -> (str, opts) -> str
function transform (filename, options) {
Expand Down Expand Up @@ -61,6 +69,7 @@ function transform (filename, options) {
// judge us too harshly, we'll work on perf ✨soon✨ -yw
const nodes = []
const babelTemplateObjects = {}
const bubleTemplateObjects = {}
const src = Buffer.concat(bufs).toString('utf8')
var mname = null
var ast
Expand Down Expand Up @@ -117,11 +126,17 @@ function transform (filename, options) {
var css
var elements

if (node.type === 'VariableDeclarator' && node.init && isBabelTemplateDefinition(node.init)) {
// Babel generates helper calls like
// _taggedTemplateLiteral([":host .class { color: hotpink; }"], [":host .class { color: hotpink; }"])
// we only keep the "cooked" part
babelTemplateObjects[node.id.name] = node.init.arguments[0]
if (node.type === 'VariableDeclarator' && node.init) {
if (isBabelTemplateDefinition(node.init)) {
// Babel generates helper calls like
// _taggedTemplateLiteral([":host .class { color: hotpink; }"], [":host .class { color: hotpink; }"])
// we only keep the "cooked" part
babelTemplateObjects[node.id.name] = node.init.arguments[0]
} else if (isBubleTemplateDefinition(node.init)) {
// Buble generates helper calls like
// Object.freeze([":host .class { color: hotpink; }"])
bubleTemplateObjects[node.id.name] = node.init.arguments[0]
}
}

if (node.type === 'TemplateLiteral' && node.parent && node.parent.tag) {
Expand All @@ -146,7 +161,12 @@ function transform (filename, options) {
} else if (node.arguments[0] && node.arguments[0].type === 'Identifier') {
// Babel generates code like
// sheetify(_templateObject)
elements = babelTemplateObjects[node.arguments[0].name].elements
var arg = node.arguments[0].name
if (babelTemplateObjects[arg]) {
elements = babelTemplateObjects[arg].elements
} else if (bubleTemplateObjects[arg]) {
elements = bubleTemplateObjects[arg].elements
}
}

if (elements) {
Expand Down