Conversation
|
thanks for this @daeho-ro CI failed (https://github.com/stackql/stackql/actions/runs/19951935381), standard check we have: can you ⭐ and ill run again 🙏 |
|
@jeffreyaven why do you require someone to star your repository in order for you to run CI for a bug fix? |
|
its just a preference @MikeMcQuaid if it is possible, we are a pure open source project, ⭐ s are our only currency, its just a standard CI check (using |
|
@jeffreyaven Thanks for explaining 😍! Homebrew (the project I've maintained for 16 years) is also a volunteer run open source project. At least to me, your request above read like "you must star this for us to merge this" which, in my humble opinion, isn't a great look. @daeho-ro opened this to fix a build error seen in Homebrew (Homebrew/homebrew-core#257025) and I fear you will disincline people from doing that if you make similar requests in future. If he was e.g. asking for support in an issue when using stackql at a for-profit large corporation: totally get it. Obviously up to you how you run your project, just thought it was worth giving some thoughts here, feel free to disregard if desired. Thanks for your work on open source software ❤️ |
|
Thanks @MikeMcQuaid you make a valid point, it was more of an ask than a requirement, and probably thinking more about features than bugs. However I will take your advice and remove it on the next PR. |
Description
go.modis updated but notgo.sumType of change
Issues referenced.
Not an issue, but PR can be refered.
Evidence
run
go mod tidyChecklist:
Variations
Tech Debt