Skip to content

fix: update go.sum#595

Merged
general-kroll-4-life merged 1 commit intostackql:mainfrom
daeho-ro:fix/go-sum
Dec 5, 2025
Merged

fix: update go.sum#595
general-kroll-4-life merged 1 commit intostackql:mainfrom
daeho-ro:fix/go-sum

Conversation

@daeho-ro
Copy link
Contributor

@daeho-ro daeho-ro commented Dec 5, 2025

Description

go.mod is updated but not go.sum

Type of change

  • Bug fix (non-breaking change to fix a bug).
  • Feature (non-breaking change to add functionality).
  • Breaking change.
  • Other (eg: documentation change). Please explain.

Issues referenced.

Not an issue, but PR can be refered.

Evidence

run go mod tidy

Checklist:

  • A full round of testing has been completed, and there are no test failures as a result of these changes.
  • The changes are covered with functional and/or integration robot testing.
  • The changes work on all supported platforms.
  • Unit tests pass locally, as per the developer guide.
  • Robot tests pass locally, as per the developer guide.
  • Linter passes locally, as per the developer guide.

Variations

Tech Debt

@jeffreyaven
Copy link
Member

thanks for this @daeho-ro CI failed (https://github.com/stackql/stackql/actions/runs/19951935381), standard check we have:

It seems you haven't starred the StackQL repositories. Please star the following repos before proceeding:
https://github.com/stackql/stackql (our core repo)
Error: Process completed with exit code 1.

can you ⭐ and ill run again 🙏

@general-kroll-4-life general-kroll-4-life merged commit 26287c8 into stackql:main Dec 5, 2025
18 of 19 checks passed
@MikeMcQuaid
Copy link

@jeffreyaven why do you require someone to star your repository in order for you to run CI for a bug fix?

@jeffreyaven
Copy link
Member

its just a preference @MikeMcQuaid if it is possible, we are a pure open source project, ⭐ s are our only currency, its just a standard CI check (using stackql itself), if someone really didn't want to star it we would still accept the PR.

@MikeMcQuaid
Copy link

@jeffreyaven Thanks for explaining 😍!

Homebrew (the project I've maintained for 16 years) is also a volunteer run open source project. At least to me, your request above read like "you must star this for us to merge this" which, in my humble opinion, isn't a great look. @daeho-ro opened this to fix a build error seen in Homebrew (Homebrew/homebrew-core#257025) and I fear you will disincline people from doing that if you make similar requests in future. If he was e.g. asking for support in an issue when using stackql at a for-profit large corporation: totally get it.

Obviously up to you how you run your project, just thought it was worth giving some thoughts here, feel free to disregard if desired. Thanks for your work on open source software ❤️

@jeffreyaven
Copy link
Member

Thanks @MikeMcQuaid you make a valid point, it was more of an ask than a requirement, and probably thinking more about features than bugs. However I will take your advice and remove it on the next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants