Skip to content

ci(scanner): remove vcs information from binary#11935

Merged
RTann merged 2 commits intomasterfrom
release-vuln-no-vcs
Jul 11, 2024
Merged

ci(scanner): remove vcs information from binary#11935
RTann merged 2 commits intomasterfrom
release-vuln-no-vcs

Conversation

@RTann
Copy link
Contributor

@RTann RTann commented Jul 10, 2024

Description

Release vulns again continue to fail. This time it's because of some invalid VCS information in the Go binary. This PR just leaves that out.

User-facing documentation

  • CHANGELOG update is not needed
  • Documentation is not needed

Testing

  • inspected CI results

Automated testing

  • contributed no automated tests

How I validated my change

Made this run on my PR prior to merge. Now that NVD API is giving 200s again, looks like it's finally running successfully. https://github.com/stackrox/stackrox/actions/runs/9878607837

@RTann RTann requested a review from a team as a code owner July 10, 2024 17:16
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jul 10, 2024

Images are ready for the commit at 083baa1.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-22-g083baa1f65.

@codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.07%. Comparing base (31a71dc) to head (8eabe2e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11935   +/-   ##
=======================================
  Coverage   48.07%   48.07%           
=======================================
  Files        2388     2388           
  Lines      170869   170869           
=======================================
+ Hits        82140    82147    +7     
+ Misses      82099    82094    -5     
+ Partials     6630     6628    -2     
Flag Coverage Δ
go-unit-tests 48.07% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RTann RTann force-pushed the release-vuln-no-vcs branch from 8eabe2e to 083baa1 Compare July 10, 2024 18:32
@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2024

@RTann: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-15-nongroovy-e2e-tests 083baa1 link false /test ocp-4-15-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@jvdm jvdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving you an approval because the follow ups, if you decide to do them, are likely to be approved as well.

@RTann RTann merged commit cc064cc into master Jul 11, 2024
@RTann RTann deleted the release-vuln-no-vcs branch July 11, 2024 13:33
shireenf-ibm pushed a commit to shireenf-ibm/stackrox that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants