ROX-26408: Encrypt Microsoft Sentinel Notifier Secret#12829
Merged
SimonBaeumer merged 6 commits intomasterfrom Oct 7, 2024
Merged
ROX-26408: Encrypt Microsoft Sentinel Notifier Secret#12829SimonBaeumer merged 6 commits intomasterfrom
SimonBaeumer merged 6 commits intomasterfrom
Conversation
Contributor
|
Images are ready for the commit at bac04ad. To use with deploy scripts, first |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12829 +/- ##
==========================================
- Coverage 48.25% 48.20% -0.06%
==========================================
Files 2441 2442 +1
Lines 175511 175702 +191
==========================================
- Hits 84694 84693 -1
- Misses 83997 84185 +188
- Partials 6820 6824 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
charmik-redhat
left a comment
There was a problem hiding this comment.
Might have to decrypt the credentials too when the notifier is used to send alert and logs.
fddc9f2 to
1e6d267
Compare
charmik-redhat
approved these changes
Oct 2, 2024
7051e81 to
b5c5554
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ROX-26408: Encrypt Microsoft Sentinel Notifier Secret
change me!
User-facing documentation
Automated testing