Skip to content

ROX-26537: update known-distributions on-demand#12930

Merged
RTann merged 1 commit intomasterfrom
ROX-26537
Oct 18, 2024
Merged

ROX-26537: update known-distributions on-demand#12930
RTann merged 1 commit intomasterfrom
ROX-26537

Conversation

@RTann
Copy link
Contributor

@RTann RTann commented Oct 7, 2024

Description

Prior to this change, we'd run into an issue when we may add support for new distributions or perhaps even change how old distributions are represented in the vuln table (this happened when we added VEX support - #12452).

When users update to the latest version, they will get a note saying we do not support an OS, when, in fact, we do. This notice will go away after the next update (hopefully), but that is currently in 24 hours.

This change hopes to prevent any questions about OS support, and it updates the list of known distributions upon each update.

This puts more load on the database, as there will be more reads, but it prevents any misunderstandings about which OSes we support

User-facing documentation

  • CHANGELOG update is not needed - This is not really documented, so no need to update this
  • documentation PR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • modified existing tests

How I validated my change

CI + deployed to a cluster. CPU usage seems ok to me

@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Oct 7, 2024

Images are ready for the commit at 4325688.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-775-g4325688d9b.

@codecov
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 78.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 48.29%. Comparing base (7292381) to head (4325688).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
scanner/matcher/updater/vuln/updater.go 21.42% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12930      +/-   ##
==========================================
+ Coverage   48.27%   48.29%   +0.01%     
==========================================
  Files        2450     2450              
  Lines      176664   176641      -23     
==========================================
+ Hits        85290    85308      +18     
+ Misses      84520    84478      -42     
- Partials     6854     6855       +1     
Flag Coverage Δ
go-unit-tests 48.29% <78.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RTann RTann force-pushed the ROX-26537 branch 3 times, most recently from 9f90570 to e451e2e Compare October 15, 2024 21:56
@RTann RTann force-pushed the ROX-26537 branch 3 times, most recently from 40e0675 to 27255c3 Compare October 17, 2024 23:15
@RTann RTann marked this pull request as ready for review October 17, 2024 23:23
@RTann RTann requested a review from a team as a code owner October 17, 2024 23:23
Copy link
Contributor

@dcaravel dcaravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2024

@RTann: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-scanner-v4-tests 4325688 link false /test gke-scanner-v4-tests
ci/prow/ocp-4-17-nongroovy-e2e-tests 4325688 link false /test ocp-4-17-nongroovy-e2e-tests
ci/prow/ocp-4-17-scanner-v4-tests 4325688 link false /test ocp-4-17-scanner-v4-tests
ci/prow/ocp-4-12-scanner-v4-tests 4325688 link false /test ocp-4-12-scanner-v4-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@RTann RTann merged commit 4407ae7 into master Oct 18, 2024
@RTann RTann deleted the ROX-26537 branch October 18, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants