Skip to content

ROX-25949: Add capability for Secured Cluster cert reissue#13143

Merged
vladbologa merged 1 commit intomasterfrom
vb/central-secured-cluster-cert-reissue-capability
Oct 29, 2024
Merged

ROX-25949: Add capability for Secured Cluster cert reissue#13143
vladbologa merged 1 commit intomasterfrom
vb/central-secured-cluster-cert-reissue-capability

Conversation

@vladbologa
Copy link
Contributor

@vladbologa vladbologa commented Oct 29, 2024 •
edited
Loading

Description

#12740 added a Central API that re-issues all the Secured Cluster certificates.

It should have included also this piece, to advertise this functionality via a capability.

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Tested by deploying with ./deploy/k8s/deploy-local.sh that the capability gets propagated to sensor.

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Oct 29, 2024 •
edited
Loading

Images are ready for the commit at 97c148f.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.6.x-837-g97c148f798.

@codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.44%. Comparing base (3fb4871) to head (97c148f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
central/sensor/service/service_impl.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #13143      +/-   ##
==========================================
- Coverage   48.45%   48.44%   -0.01%     
==========================================
  Files        2464     2464              
  Lines      177913   177914       +1     
==========================================
- Hits        86209    86196      -13     
- Misses      84768    84780      +12     
- Partials     6936     6938       +2
Flag Coverage Δ
go-unit-tests 48.44% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vladbologa vladbologa force-pushed the vb/central-secured-cluster-cert-reissue-capability branch from a8f817f to 97c148f Compare October 29, 2024 13:06
@vladbologa
Copy link
Contributor Author

vladbologa commented Oct 29, 2024

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 29, 2024 •
edited
Loading

@vladbologa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-qa-e2e-tests 97c148f link false /test ocp-4-12-qa-e2e-tests
ci/prow/ocp-4-12-operator-e2e-tests 97c148f link false /test ocp-4-12-operator-e2e-tests
ci/prow/ocp-4-12-ui-e2e-tests 97c148f link false /test ocp-4-12-ui-e2e-tests
ci/prow/ocp-4-12-nongroovy-e2e-tests 97c148f link false /test ocp-4-12-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vladbologa
Copy link
Contributor Author

vladbologa commented Oct 29, 2024

/test gke-ui-e2e-tests

@vladbologa
Copy link
Contributor Author

vladbologa commented Oct 29, 2024

/test gke-qa-e2e-tests

@vladbologa
Copy link
Contributor Author

vladbologa commented Oct 29, 2024

/test ocp-4-17-operator-e2e-tests

@vladbologa vladbologa merged commit 8d444d4 into master Oct 29, 2024
@vladbologa vladbologa deleted the vb/central-secured-cluster-cert-reissue-capability branch October 29, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@porridge porridge porridge approved these changes

@mclasmeier mclasmeier Awaiting requested review from mclasmeier

Assignees

No one assigned

Labels

area/central

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vladbologa @rhacs-bot @porridge