Skip to content

ROX-26889: Build main source image without Cachi2 artifact#13238

Merged
msugakov merged 2 commits intomasterfrom
misha/no-main-cachi2-sources-konflux
Nov 7, 2024
Merged

ROX-26889: Build main source image without Cachi2 artifact#13238
msugakov merged 2 commits intomasterfrom
misha/no-main-cachi2-sources-konflux

Conversation

@msugakov
Copy link
Contributor

@msugakov msugakov commented Nov 6, 2024 •
edited
Loading

Description

As a workaround for https://issues.redhat.com/browse/KFLUXBUGS-1508

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

No contributions to automated tests.

How I validated my change

There's a chance Konflux EC won't be happy with the image, I'd request policy exception as part of the same task ROX-26889

@openshift-ci
Copy link

openshift-ci bot commented Nov 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@msugakov msugakov changed the title Build main source without Cachi2 artifact Build main source image without Cachi2 artifact Nov 6, 2024
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Nov 6, 2024 •
edited
Loading

Images are ready for the commit at c04c28f.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-57-gc04c28fef7.

@codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.50%. Comparing base (2d37fc2) to head (587d80f).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #13238      +/-   ##
==========================================
- Coverage   48.50%   48.50%   -0.01%     
==========================================
  Files        2468     2468              
  Lines      178011   178011              
==========================================
- Hits        86347    86344       -3     
- Misses      84731    84734       +3     
  Partials     6933     6933
Flag Coverage Δ
go-unit-tests 48.50% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msugakov
Copy link
Contributor Author

msugakov commented Nov 6, 2024

/retest main-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Nov 6, 2024
@msugakov
Copy link
Contributor Author

msugakov commented Nov 6, 2024

/test main-on-push

1 similar comment
@msugakov
Copy link
Contributor Author

msugakov commented Nov 6, 2024

/test main-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Nov 6, 2024
@stackrox stackrox deleted a comment from openshift-ci bot Nov 6, 2024
@msugakov msugakov force-pushed the misha/no-main-cachi2-sources-konflux branch from fb36db0 to 587d80f Compare November 6, 2024 17:37
@msugakov msugakov changed the title Build main source image without Cachi2 artifact ROX-26889: Build main source image without Cachi2 artifact Nov 6, 2024
@msugakov
Copy link
Contributor Author

msugakov commented Nov 6, 2024

/test main-on-push

@openshift-ci

This comment was marked as outdated.

Sign in to view
@msugakov msugakov force-pushed the misha/no-main-cachi2-sources-konflux branch from 587d80f to c04c28f Compare November 7, 2024 10:02
@msugakov msugakov added the backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 label Nov 7, 2024
@msugakov msugakov marked this pull request as ready for review November 7, 2024 10:04
@msugakov msugakov requested a review from a team as a code owner November 7, 2024 10:04
@msugakov
Copy link
Contributor Author

msugakov commented Nov 7, 2024

For the local run of ec CLI, I get only a few of

✕ [Violation] slsa_source_correlated.source_code_reference_provided
  ImageRef: quay.io/rhacs-eng/main@sha256:d9d0ace3d7fb5d3effe6ce2497b8fa58ad1e7f874dbb28c397115d6e14e559ba
  Reason: Expected source code reference was not provided for verification

which could be a red herring.

@msugakov msugakov requested a review from tommartensen November 7, 2024 10:40
@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2024

@msugakov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-17-nongroovy-e2e-tests c04c28f link false /test ocp-4-17-nongroovy-e2e-tests
ci/prow/ocp-4-12-nongroovy-e2e-tests c04c28f link false /test ocp-4-12-nongroovy-e2e-tests
ci/prow/gke-sensor-integration-tests c04c28f link false /test gke-sensor-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@msugakov
Copy link
Contributor Author

msugakov commented Nov 7, 2024

/test main-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Nov 7, 2024
@msugakov
Copy link
Contributor Author

msugakov commented Nov 7, 2024

/test acs-enterprise-contract / main

@stackrox stackrox deleted a comment from openshift-ci bot Nov 7, 2024
@msugakov
Copy link
Contributor Author

msugakov commented Nov 7, 2024

/test main-on-push

@openshift-ci

This comment was marked as outdated.

Sign in to view
@msugakov
Copy link
Contributor Author

msugakov commented Nov 7, 2024

/test main-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Nov 7, 2024
@msugakov
Copy link
Contributor Author

msugakov commented Nov 7, 2024

I'm going to merge it now and catch up with EC results after. Will keep the task open for that.

@msugakov msugakov merged commit e4bcdff into master Nov 7, 2024
@msugakov msugakov deleted the misha/no-main-cachi2-sources-konflux branch November 7, 2024 18:35
aaa5kameric pushed a commit that referenced this pull request Nov 14, 2024
@msugakov @aaa5kameric
ROX-26889: Build main source image without Cachi2 artifact (#13238)
a3f55ba
ajheflin pushed a commit that referenced this pull request Jun 24, 2025
@msugakov @ajheflin
ROX-26889: Build main source image without Cachi2 artifact (#13238)
d0d8e2c
@ajheflin ajheflin mentioned this pull request Jun 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tommartensen tommartensen tommartensen approved these changes

Assignees

No one assigned

Labels

backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msugakov @rhacs-bot @tommartensen