ROX-26719: Extract common TLS issuer code#13260
Merged
vladbologa merged 1 commit intomasterfrom Nov 7, 2024
Merged
Conversation
9 tasks
Contributor
|
Images are ready for the commit at afd1906. To use with deploy scripts, first |
Contributor
Author
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13260 +/- ##
==========================================
- Coverage 48.50% 48.49% -0.01%
==========================================
Files 2468 2468
Lines 178011 178011
==========================================
- Hits 86345 86335 -10
- Misses 84733 84741 +8
- Partials 6933 6935 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR only moves code from
localscanner_tls_issuer*totls_issuer_common*, to make reviewing #13229 easier.The follow-up PR will introduce a new TLS issuer, and this code is shared by both.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Existing tests are sufficient, I just moved code in a different file in the same package.