Skip to content

ROX-26949: EC wip#13294

Closed
msugakov wants to merge 4 commits intomasterfrom
misha/ROX-24468-ec-thingies
Closed

ROX-26949: EC wip#13294
msugakov wants to merge 4 commits intomasterfrom
misha/ROX-24468-ec-thingies

Conversation

@msugakov
Copy link
Contributor

Description

change me!

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@msugakov msugakov added the konflux-build Run Konflux in PR. Push commit to trigger it. label Nov 11, 2024
@openshift-ci
Copy link

openshift-ci bot commented Nov 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@msugakov msugakov changed the title ROX-24468: EC wip ROX-26949: EC wip Nov 11, 2024
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Nov 11, 2024

Images are ready for the commit at 3c8e99b.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-93-g3c8e99b69d.

@codecov
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.55%. Comparing base (1b7f1f2) to head (3c8e99b).
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13294   +/-   ##
=======================================
  Coverage   48.55%   48.55%           
=======================================
  Files        2467     2467           
  Lines      177781   177781           
=======================================
  Hits        86320    86320           
- Misses      84533    84534    +1     
+ Partials     6928     6927    -1     
Flag Coverage Δ
go-unit-tests 48.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msugakov
Copy link
Contributor Author

Nope. Would be #13309

@msugakov msugakov closed this Nov 13, 2024
@msugakov msugakov deleted the misha/ROX-24468-ec-thingies branch September 10, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants