ROX-26698: Remove ignored operator channel labels#13341
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at f6b8943. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13341 +/- ##
==========================================
+ Coverage 48.50% 48.54% +0.04%
==========================================
Files 2470 2470
Lines 178320 178403 +83
==========================================
+ Hits 86487 86599 +112
+ Misses 84900 84873 -27
+ Partials 6933 6931 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
/retest |
Its value does not play any role after we actually published 4.0.0 and 4.1.0 (which was long ago) but it is appealing to keep the values right. First version 4.0.0 signifies that our upgrade graph was broken on it.
252e785 to
c2461dc
Compare
Contributor
Author
|
/retest ke-operator-e2e-tests |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
/retest gke-operator-e2e-tests |
Contributor
Author
|
/retest ocp-4-17-operator-e2e-tests |
Contributor
Author
|
/test gke-operator-e2e-tests |
Contributor
Author
|
/test ocp-4-17-operator-e2e-tests |
Because I want it gone.
This reverts commit 1a8bff0. Because there are more operator-sdk bundle validate calls down the line.
porridge
approved these changes
Nov 18, 2024
tommartensen
approved these changes
Nov 18, 2024
mclasmeier
pushed a commit
that referenced
this pull request
Nov 21, 2024
mclasmeier
pushed a commit
that referenced
this pull request
Nov 22, 2024
mclasmeier
pushed a commit
that referenced
this pull request
Nov 22, 2024
ajheflin
pushed a commit
that referenced
this pull request
Jun 24, 2025
msugakov
added a commit
that referenced
this pull request
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Here I remove misleading channel labels from GHA- and Konflux-built bundle Dockerfiles.
In both cases the operator channels are managed explicitly.
In case of GHA, it's done in this script
stackrox/operator/hack/build-index-image.sh
Lines 137 to 143 in 252e785
In case of Konflux, channels are managed in https://github.com/stackrox/operator-index/ repo.
I did not remove it from
stackrox/operator/bundle/metadata/annotations.yaml
Line 7 in 4589087
because I could not make it work against multiple
operator-sdk bundle validatecalls which would fail:This asks for disentangling
Makefiletargets (starting fromindex-build->bundle-post-process) and so is likely a big fun for another time.Also, I correct
--first-versionin Konfluxpatch-csv.pycall. It is an unrelated change and it has no practical effect but makes the code more truthy.User-facing documentation
Testing and quality
Automated testing
No automated testing changes.
How I validated my change
Relying on CI.