Skip to content

ROX-24276: Enable release builds on Konflux with GOTAGS #13348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tommartensen merged 1 commit into from
Nov 29, 2024
Merged

ROX-24276: Enable release builds on Konflux with GOTAGS #13348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions image/rhel/konflux.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,8 @@ ENV MAIN_TAG_SUFFIX="$VERSIONS_SUFFIX" COLLECTOR_TAG_SUFFIX="$VERSIONS_SUFFIX" S

ENV GOFLAGS=""
ENV CGO_ENABLED=1
# TODO(ROX-24276): re-enable release builds for fast stream.
# TODO(ROX-20240): enable non-release development builds.
# ENV GOTAGS="release"
ENV GOTAGS="release"
ENV CI=1

RUN # TODO(ROX-13200): make sure roxctl cli is built without running go mod tidy. \
Expand Down
3 changes: 1 addition & 2 deletions image/roxctl/konflux.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,8 @@ ARG VERSIONS_SUFFIX
ENV MAIN_TAG_SUFFIX="$VERSIONS_SUFFIX" COLLECTOR_TAG_SUFFIX="$VERSIONS_SUFFIX" SCANNER_TAG_SUFFIX="$VERSIONS_SUFFIX"

ENV CI=1 GOFLAGS=""
# TODO(ROX-24276): re-enable release builds for fast stream.
# TODO(ROX-20240): enable non-release development builds.
# ENV GOTAGS="release"
ENV GOTAGS="release"

RUN RACE=0 CGO_ENABLED=1 GOOS=linux GOARCH=$(go env GOARCH) scripts/go-build.sh ./roxctl && \
cp bin/linux_$(go env GOARCH)/roxctl image/bin/roxctl
Expand Down
3 changes: 1 addition & 2 deletions operator/konflux.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@ ARG VERSIONS_SUFFIX
ENV MAIN_TAG_SUFFIX="$VERSIONS_SUFFIX" COLLECTOR_TAG_SUFFIX="$VERSIONS_SUFFIX" SCANNER_TAG_SUFFIX="$VERSIONS_SUFFIX"

# Build the operator binary.
# TODO(ROX-24276): re-enable release builds for fast stream.
# TODO(ROX-20240): enable non-release development builds.
# GOTAGS="release"
ENV GOTAGS="release"
ENV CI=1 GOFLAGS="" CGO_ENABLED=1

RUN GOOS=linux GOARCH=$(go env GOARCH) scripts/go-build-file.sh operator/cmd/main.go image/bin/operator
Expand Down
3 changes: 1 addition & 2 deletions scanner/image/scanner/konflux.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@ ARG BASE_TAG=latest
FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_8_1.22 AS builder

ENV GOFLAGS=""
# TODO(ROX-24276): re-enable release builds for fast stream.
# TODO(ROX-20240): enable non-release development builds.
# ENV GOTAGS="release"
ENV GOTAGS="release"
# TODO(ROX-23335): Properly set the build tag
ENV BUILD_TAG="dev"
ENV CI=1
Expand Down