Skip to content

ROX-10217: Remove format validation from URL field of generic webhook integration form#1342

Merged
vjwilson merged 1 commit intomasterfrom
ROX-10217-remove-specific-validation-for-generic-webhook-url
Apr 19, 2022
Merged

ROX-10217: Remove format validation from URL field of generic webhook integration form#1342
vjwilson merged 1 commit intomasterfrom
ROX-10217-remove-specific-validation-for-generic-webhook-url

Conversation

@vjwilson
Copy link
Contributor

@vjwilson vjwilson commented Apr 19, 2022

Description

  1. Customer had an issue with a webhook URL that had previously worked when we had no front-end validation of the URL field in Generic Webhook integration form. After upgrading to a version that has the new form, they cannot edit or create new integrations. Based on a sanitized version, it appears that their URL was failing due to the presence of a % character, as part of URL encoding.
  2. There have been other issues, on other forms' endpoint fields, where customers have used a variety of formats, including Kubernetes service names instead of traditional URL formats.

Rather than only address the immediate issue in #1 above, by adding % to the validation regex, I decided to allow for #2 as well. Therefore, I removed all specific validation, and just made the field required.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required

Testing Performed

  • Updated e2e test
  • Manual testing

Screen Shot 2022-04-19 at 11 24 25 AM

@ghost
Copy link

ghost commented Apr 19, 2022

Tag for build #447120 is 3.69.x-427-g59e44a6833.

💻 For deploying this image using the dev scripts, run the following first:

export MAIN_IMAGE_TAG='3.69.x-427-g59e44a6833'

🕹️ A roxctl binary can be downloaded from the CircleCI artifacts.

Copy link
Contributor

@sachaudh sachaudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More regex mods 😢

@vjwilson vjwilson merged commit 144c8ab into master Apr 19, 2022
@vjwilson vjwilson deleted the ROX-10217-remove-specific-validation-for-generic-webhook-url branch April 19, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants