Skip to content

chore: Improve Renovate behavior#13485

Merged
msugakov merged 4 commits intomasterfrom
misha/improve-renovate-konflux
Dec 2, 2024
Merged

chore: Improve Renovate behavior#13485
msugakov merged 4 commits intomasterfrom
misha/improve-renovate-konflux

Conversation

@msugakov
Copy link
Contributor

@msugakov msugakov commented Dec 2, 2024

Description

Please review this change per commits. I provided commit message in each.

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

No automated testing.

How I validated my change

Ran renovate-config-validator and it said all's ok.

because our PRs all seem to inherit the default one. E.g.
#13477 says

> Schedule: Branch creation - "after 5am on saturday" in timezone Etc/UTC, Automerge - At any time (no schedule defined).
to have less diffs in the future. JSON5 is so much nicer than JSON,
It becomes burdensome to deal with the separate ones which get cut
around the same time. E.g.
#13479
#13478
#13477

What for? I don't see a valid reason.
I suggest to combine all such PRs in one for now until we have a case
for separation.

Used answers here as inspiration
https://stackoverflow.com/questions/66471226/renovate-combine-all-updates-to-one-branch-pr

I don't know yet if this will work. We need to merge, wait and see.
Launching the old command failed because the location has changed
from `/usr/local/bin/` to `/usr/local/sbin/`.
We don't need to know it at all as long as the executable is in the
`$PATH`.
@msugakov msugakov added the backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 label Dec 2, 2024
@msugakov msugakov requested a review from tommartensen December 2, 2024 11:13
@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 17d11d9.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-208-g17d11d9067.

@msugakov msugakov enabled auto-merge (squash) December 2, 2024 12:19
@msugakov msugakov merged commit 6415c11 into master Dec 2, 2024
@msugakov msugakov deleted the misha/improve-renovate-konflux branch December 2, 2024 12:30
@msugakov
Copy link
Contributor Author

msugakov commented Dec 3, 2024

At least step image changes get grouped now #13493

msugakov added a commit to stackrox/scanner that referenced this pull request Dec 3, 2024
taking the recent one from StackRox.
See stackrox/stackrox#13485
msugakov added a commit to stackrox/collector that referenced this pull request Dec 3, 2024
taking the recent one from StackRox.
See stackrox/stackrox#13485
@msugakov msugakov removed the backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 label Dec 3, 2024
@msugakov
Copy link
Contributor Author

msugakov commented Dec 3, 2024

Removed label: no need to backport. The config appears to be read from the main branch. E.g. #13494

ajheflin pushed a commit that referenced this pull request Jun 24, 2025
msugakov added a commit that referenced this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants