ROX-2602: Prefactors for tagging support in Konflux#13661
Merged
Conversation
I believe it's just unused https://redhat-internal.slack.com/archives/C073B14UE10/p1732281912631549
Versions like 3.0.62.3 are long gone and are not coming back, we don't need to keep the code which strips out the .0 on the second position.
This was the case before I came but I was still first surprised that my `misha-test-1` tag push triggered `release-ci.yaml`. There I couldn't quickly figure if things would indeed be released.
Also simplified a couple of related loops because it has been long since we pushed to multiple repos at once and I'm not sure we'll need it again.
Contributor
|
Images are ready for the commit at f9f45ae. To use with deploy scripts, first |
porridge
approved these changes
Jan 2, 2025
tommartensen
reviewed
Jan 2, 2025
tommartensen
approved these changes
Jan 2, 2025
porridge
approved these changes
Jan 2, 2025
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
tommartensen
approved these changes
Jan 2, 2025
Contributor
Author
|
/retest main-on-push |
|
@msugakov: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
Author
|
/retest main-on-push |
4 tasks
ajheflin
pushed a commit
that referenced
this pull request
Jun 24, 2025
msugakov
added a commit
that referenced
this pull request
Jun 25, 2025
msugakov
added a commit
that referenced
this pull request
Jun 25, 2025
msugakov
added a commit
that referenced
this pull request
Jun 25, 2025
from shellcheck skip-list to aid failing CI. See https://github.com/stackrox/stackrox/actions/runs/15883188504/job/44788581256?pr=15816#step:7:7375 This follows up deletions cherry-picked from #13661 I wonder why it did not fail there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Here's a collection of commits not related to each other but related to the task of properly supporting tagged builds in Konflux. I suggest reviewing this change per-commit because I provided relevant messages.
Nerdy context: the commits here were cherry-picked from my biggish PR #13422 which anyway needs to be redone because it's big and due to tasks move to a new repo.
User-facing documentation
Testing and quality
Automated testing
Some tests added.
How I validated my change
Just relying on CI and/or that it "should just work" if not covered by CI.